github-actions[bot] commented on PR #26177: URL: https://github.com/apache/datafusion/pull/26177#issuecomment-6095171168
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v55.1.0 (current) Built [ 23.208s] (current) Parsing datafusion-expr v55.1.0 (current) Parsed [ 0.067s] (current) Building datafusion-expr v55.1.0 (baseline) Built [ 23.782s] (baseline) Parsing datafusion-expr v55.1.0 (baseline) Parsed [ 0.067s] (baseline) Checking datafusion-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.141s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_parameter_count_changed.ron Failed in: ExprPlanner::plan_scalar now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/planner.rs:269 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 50.122s] datafusion-expr Building datafusion-sql v55.1.0 (current) Built [ 31.991s] (current) Parsing datafusion-sql v55.1.0 (current) Parsed [ 0.025s] (current) Building datafusion-sql v55.1.0 (baseline) Built [ 32.749s] (baseline) Parsing datafusion-sql v55.1.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-sql v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.185s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 66.126s] datafusion-sql ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
