rich7420 opened a new pull request, #6846: URL: https://github.com/apache/datafusion-comet/pull/6846
## Which issue does this PR close? Closes #6164. ## Rationale for this change The strict Scala profile currently excludes unused parameters, so dead helper arguments go unnoticed. ## What changes are included in this PR? - Enable unused-parameter warnings for main and test sources. - Remove unused helper arguments and update callers, preserving required JNI, shim, extractor and extension-hook signatures with scoped filters. - Handle existing shuffle annotations that are needed on Scala 2.13 but reported as unused on Scala 2.12. Rebased onto main `bfacc43a5`; the prerequisite #5876 is already merged. Scala 2.13 strict-warning cleanup remains tracked in #5893. ## How are these changes tested? - Root-reactor Spark 3.5 strict `test-compile` and clean Spark 4.1 `test-compile` passed, including Spotless and Scalastyle. - A compiler probe accepts the intended Native exception and rejects an unused parameter in NativeHelper. - Verified matching filters in both compiler executions and preservation of all test declarations in the two updated Iceberg suites. Runtime Spark SQL and Iceberg suites have not been rerun for this change. Please apply `run-spark-4.1-tests` and `run-iceberg-tests`; keep Draft pending CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
