patrickswedish opened a new pull request, #26189: URL: https://github.com/apache/datafusion/pull/26189
## Which issue does this PR close? Closes #26181. ## Rationale for this change Running \cargo clippy --all-targets --all-features -- -D warnings\ fails in \datafusion-optimizer\ with three \clippy::mutable_key_type\ errors in \datafusion/optimizer/src/push_down_filter.rs\. This happens because \extract_partition_keys\, \potential_partition_keys\, and \ eads_only_partition_keys\ collect and check partition keys using \HashSet<&Expr>\. Because \Expr\ transitively contains \ScalarValue\ with buffer allocations, Clippy flags \&Expr\ as possessing interior mutability. Throughout DataFusion (\datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs\, \datafusion/optimizer/src/analyzer/resolve_grouping_function.rs\, \datafusion/expr/src/logical_plan/plan.rs\, etc.), the standard resolution is to annotate intentional \Expr\ hash keys with \#[allow(clippy::allow_attributes, clippy::mutable_key_type)]\. ## What changes are included in this PR? - Annotate \extract_partition_keys\, \potential_partition_keys\, and \ eads_only_partition_keys\ with \#[allow(clippy::allow_attributes, clippy::mutable_key_type)]\ in \datafusion/optimizer/src/push_down_filter.rs\. ## What is the testing strategy for this PR? - \cargo check -p datafusion-optimizer --all-targets --all-features\ passes cleanly without warnings. - \cargo test -p datafusion-optimizer --lib\ passes all 932 unit tests. - \ ustfmt --check datafusion/optimizer/src/push_down_filter.rs\ verified clean formatting. ## Are there any user-facing changes? None. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
