MartinKolbAtWork commented on PR #12227: URL: https://github.com/apache/datafusion/pull/12227#issuecomment-2322846560
Hi @findepi , thanks again for assisting me to get the PR in a “mergeable” state. Really appreciate your input. Your comment on the change regarding the timestamp behavior made me think that we might take one step back. These changes related to the timestamp handling were added to support negative years. The initial target for this PR is fixing the problem of handling years greater than 2262. I found your suggestion about supporting negative years very compelling, because it semantically addresses a similar edge case. Now that we found out that adding support for negative years does add several nitty-gritty details, that need to be carefully thought through, I suggest that we split this up and handle the negative years topic in a separate PR. I reverted the changes back to the point where it’s only about supporting years up to 9999. This makes the code simpler and easier to understand. Hope this makes sense for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
