rich7420 opened a new pull request, #6863:
URL: https://github.com/apache/datafusion-comet/pull/6863

   ## Which issue does this PR close?
   
   Part of #6627 and #6615.
   
   ## Rationale for this change
   
   Move Java RLIKE semantics into SQL fixtures with explicit dispatch 
assertions. Fix the old multi-batch case, whose input fit in the default batch 
size and whose anchored pattern never matched.
   
   ## What changes are included in this PR?
   
   - Extend `rlike_java.sql` with substring matching, backreferences, 
lookarounds, flags, named groups, NULL/empty subjects and grouped filtering. 
Preserve native empty-pattern coverage.
   - Add a 5,000-row, 64-row-batch fixture with recurring matches, nonmatches 
and NULLs, retaining row IDs in projection and filter results.
   - Remove the 13 migrated Scala cases and unused helpers. The remaining 61 
test bodies are unchanged.
   
   ## How are these changes tested?
   
   Spark 4.1.3 / JDK 21 with matching native/JVM builds: both SQL fixtures and 
`CometRegExpJvmSuite` passed, with 62 tests successful and one expected 
Spark-4.0-only cancellation. Formatting checks pass.
   
   A separate runtime probe confirmed one input file/partition and 79 
projection batches (78 × 64 + 8), with matches, nonmatches and NULLs across 
batches. Both queries passed Spark parity and Java dispatch assertions.
   
   Other Comet Spark profiles remain pending; request `run-all-spark-profiles` 
before queueing.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to