terbed opened a new pull request, #59: URL: https://github.com/apache/datafusion-iceberg/pull/59
Closes #36 Closes #44 Unsafe column casts can produce pushed predicates that discard matching rows or fail to bind. This change leaves remaining column casts for DataFusion to evaluate, evaluates literal casts with their target types, and skips predicates that cannot bind to the scan schema. It also tracks partially converted predicates and prevents their negation. Dropping an unsupported condition from `A AND B` can be safe for pushdown; negating the remaining condition is not. Rejecting column casts can produce such partial predicates, which connects the two fixes. The #44 safeguard covers direct callers of the public converter and filters reaching it without simplification. DataFusion's default SQL optimizer normally rewrites these negated compound expressions before pushdown. Tests cover cast conversion, invalid and overflowing literal casts, nulls, nested Boolean expressions, and query-result comparisons against a MemTable through both static and catalog-backed providers. They also verify that supported pushdown remains active. No public API or dependency changes. Validation: ``` - cargo fmt --all -- --check - cargo clippy --workspace --locked --all-targets -- -D warnings - cargo test --workspace --locked - git diff --check ``` --- AI assistance: OpenAI Codex assisted with implementation and tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
