akshaychitneni commented on code in PR #2568:
URL:
https://github.com/apache/datafusion-ballista/pull/2568#discussion_r4242370496
##########
ballista/scheduler/src/cluster/mod.rs:
##########
@@ -77,17 +82,21 @@ pub struct BallistaCluster {
cluster_state: Arc<dyn ClusterState>,
/// State for tracking jobs and their execution progress.
job_state: Arc<dyn JobState>,
+ /// State for tracking materialized `DataFrame::cache()` results.
+ cache_state: Arc<dyn CacheState>,
}
impl BallistaCluster {
/// Creates a new `BallistaCluster` with the given state backends.
pub fn new(
cluster_state: Arc<dyn ClusterState>,
job_state: Arc<dyn JobState>,
+ cache_state: Arc<dyn CacheState>,
Review Comment:
thanks for pointing out. Updated to make sure to not introduce api change by
defaulting to InMemoryCacheState
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
