gabotechs opened a new pull request, #64: URL: https://github.com/apache/datafusion-iceberg/pull/64
Replace the integration tests’ `expect-test` assertions with inline `insta` snapshots and remove the direct `expect-test` dev-dependency. Use Arrow’s `pretty_format_batches` for result snapshots and full schema snapshots to preserve assertions on types, nullability, and field metadata. Empty metadata tables also assert that every batch has zero rows, and the insert query uses `ORDER BY` to keep results deterministic. Update the snapshot review command in `AGENTS.md`. `expect-test` remains a transitive dependency of the pinned upstream Iceberg crate. Validation: - `cargo fmt --all -- --check` - `cargo clippy --workspace --locked --all-targets -- -D warnings` - `cargo test --workspace --locked` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
