github-actions[bot] commented on PR #25944: URL: https://github.com/apache/datafusion/pull/25944#issuecomment-6130851150
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-proto v55.1.0 (current) Built [ 48.791s] (current) Parsing datafusion-proto v55.1.0 (current) Parsed [ 0.014s] (current) Building datafusion-proto v55.1.0 (baseline) Built [ 48.396s] (baseline) Parsing datafusion-proto v55.1.0 (baseline) Parsed [ 0.015s] (baseline) Checking datafusion-proto v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.178s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 99.166s] datafusion-proto Building datafusion-proto-models v55.1.0 (current) Built [ 21.978s] (current) Parsing datafusion-proto-models v55.1.0 (current) Parsed [ 0.139s] (current) Building datafusion-proto-models v55.1.0 (baseline) Built [ 21.947s] (baseline) Parsing datafusion-proto-models v55.1.0 (baseline) Parsed [ 0.142s] (baseline) Checking datafusion-proto-models v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 2.831s] 223 checks: 221 pass, 2 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field EmptyRelationNode.schema in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:272 field EmptyRelationNode.schema in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:272 --- failure derive_trait_impl_removed: built-in derived trait no longer implemented --- Description: A public type has stopped deriving one or more traits. This can break downstream code that depends on those types implementing those traits. ref: https://doc.rust-lang.org/reference/attributes/derive.html#derive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/derive_trait_impl_removed.ron Failed in: type EmptyRelationNode no longer derives Copy, in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:268 type EmptyRelationNode no longer derives Eq, in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:268 type EmptyRelationNode no longer derives Hash, in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:268 type EmptyRelationNode no longer derives Copy, in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:268 type EmptyRelationNode no longer derives Eq, in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:268 type EmptyRelationNode no longer derives Hash, in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:268 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 48.338s] datafusion-proto-models ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
