LucaCappelletti94 commented on PR #2610: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2610#issuecomment-6133944891
Please do not be a [meat proxy](https://gruhn.me/blog/2026-08-03/) as I did spend my own time reading and trying to make sense of the code. On the `table:namespace` syntax, deciding which part is the namespace is name resolution, which this crate leaves to its users. A dialect whose `is_identifier_part` accepts `:` parses `analytics:events` as one identifier in `FROM`, `INSERT INTO`, `CREATE TABLE`, `DROP TABLE`, `ALTER TABLE`, `UPDATE` and `DELETE`, and prints it back unchanged, so the caller can split it where it resolves table names. The cost is that `a::INT` then lexes as one identifier. The hook would not replace the token rewrite either, because it only reaches table factors, and `INSERT INTO analytics:events` and `CREATE TABLE analytics:events` would still fail. As I wrote in my [previous reply](https://github.com/apache/datafusion-sqlparser-rs/pull/2610#issuecomment-6132233811), the long-term answer is a tokenizer generic over the dialect. I will work on it if and when I have the time, as I am interested in improving its performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
