txwyy123 commented on PR #26149: URL: https://github.com/apache/datafusion/pull/26149#issuecomment-6129057398
All three review comments addressed in the latest push (b4e0528): 1. **counted_arrays bug**: fixed — now uses `HashMap<usize, u32>` with refcounting. Added your repro test. 2. **Benchmark regression**: fixed — split inline storage into separate `ids` and `counts` arrays (128 + 64 bytes) instead of interleaved tuples (256 bytes). 3. **Test trim**: done — added uncount round-trip to the existing layout test helper, collapsed 17 standalone round-trip tests into one table-driven test. Net: -716 / +296 lines. 26 tests pass, clippy clean, benchmarks show no regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
