RishavTiwari25 commented on issue #26223: URL: https://github.com/apache/datafusion/issues/26223#issuecomment-6140056267
That overflow case looks different from the reassociation one to me: every `x + 1e308` is exactly 0, so `SUM(x + 1e308)` is 0 in any summation order, while the rewritten form goes through `SUM(x) = -Infinity` and ends up `NaN`. The rewrite creates intermediate magnitudes the original expression never has. @alamb if you think that is worth guarding against, I can reopen #26241 with this overflow case as the test, the guard itself is the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
