ASVLCII opened a new issue, #26259: URL: https://github.com/apache/datafusion/issues/26259
### Describe the bug The release changelog generator crashes when a commit's author is not linked to a GitHub account, even though the commit contains a Git author name. A release range containing such a commit cannot finish generating its changelog. An actual DataFusion example is [63ce4865896b906ca34fcbf85fdc55bff3080c30](https://github.com/apache/datafusion/commit/63ce4865896b906ca34fcbf85fdc55bff3080c30), associated with #13794. The GitHub commit API currently returns `author: null` and `commit.author.name: "mertak-synnada"`. ### Reproduction On main `2c568b478b3aff18de52609c7237f1c3f494d5b1`, with PyGithub installed, this offline reproduction calls the real rendering function: ```python import runpy from types import SimpleNamespace module = runpy.run_path("dev/release/generate-changelog.py") pull = SimpleNamespace(number=13794, title="Example change") commit = SimpleNamespace( author=None, commit=SimpleNamespace(author=SimpleNamespace(name="mertak-synnada")), ) module["print_pulls"]("apache/datafusion", "Fixed bugs", [(pull, commit)]) ``` It raises `AttributeError: 'NoneType' object has no attribute 'login'` when rendering the entry. ### Expected behavior Keep the existing GitHub username when the commit has a linked account. Otherwise render the author name recorded in Git, allowing changelog generation to continue without guessing an account. ### Additional context The same failure was reproduced using real PyGithub decoding of the affected API payload shape, including through complete changelog generation with repository/subprocess calls mocked. A focused local patch passes four regression tests; two fail before the fix. The patch has not been submitted because the repository-required Rust checks have not passed in the current Windows environment. No Rust runtime behavior changes are proposed. AI assistance: Codex assisted with investigation, the local patch, tests and this report. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
