haochunchang commented on issue #26257: URL: https://github.com/apache/datafusion/issues/26257#issuecomment-6145480938
Just want to chime-in with my two-cents. :) imo it is the drift between mental model and real codebase that will cause doubt/fear. By addressing this, I still read through the AI generated code changes (and/or asking questions or use something like [explain-diff skill](https://github.com/Chris-Graffagnino/explain-diff) to quiz myself) to understand as thoroughly as time allowed. As one of the action items, my idea is to add safety rails that could help us understand the code changes, for example: - making sure the behaviors are changing the way we expect - making sure how the changes would affect the library users - splitting changes into smaller PR to help us understand. Maybe starting by refining the contributor guides [section](https://datafusion.apache.org/contributor-guide/ai-policy.html#ai-assisted-reviews) to be the context for AI review agents? For performance, maybe encouraging PR authors to run benchmark to see if the changes would have performance degradation (since my understanding is that performance is really essential for datafusion)? I also like the PR limits for each user, so that we can focus on what we have started. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
