masonh22 commented on PR #25710: URL: https://github.com/apache/datafusion/pull/25710#issuecomment-6149871738
@alamb it looks like CI failed in the hash collisions mode for the test I added because `HyperLogLog` doesn't do anything different when the hash collisions feature is enabled, but the groups accumulator for `approx_distinct()` does, so they end up generating different values. I went ahead and updated `HyperLogLog` so that it produces hash collisions when the feature is enabled. The hash collision tests passed on my machine with this change. Alternatively, I could disable the test I added when the hash collision feature is enabled. Let me know what you would prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
