zhangfengcdt commented on code in PR #6928:
URL: https://github.com/apache/datafusion-comet/pull/6928#discussion_r4259974809
##########
native/spark-expr/src/agg_funcs/percentile.rs:
##########
@@ -238,6 +266,8 @@ impl GroupsAccumulator for SparkPercentileGroupsAccumulator
{
fn state(&mut self, emit_to: EmitTo) -> Result<Vec<ArrayRef>> {
let emit_group_values = emit_to.take_needed(&mut self.group_values);
+ // A state holds no boundaries, so a later merge sees these values as
one partial.
+ emit_to.take_needed(&mut self.group_partial_ends);
Review Comment:
Yes, that is fair observation. I changed the state to include values and
partial_ends so that it should keep the partitial boundaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
