LucaCappelletti94 opened a new pull request, #2628: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2628
This series of PRs, of which this is by far the largest one, will allow us to avoid re-occurrences of the silent error I found earlier today, i.e. an expression failing but not in the expected manner. Negative tests written as `assert!(result.is_err())` pass when parsing fails for any reason, so a regression that fails earlier for an unrelated reason goes unnoticed. This pins the exact `ParserError` at the 81 such sites for postgres. `ADD FUNCTION 1 () func` was commented as missing the argument parentheses, which PostgreSQL accepts. PostgreSQL rejects the empty `()`, and the comment now says so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
