devanbenz commented on code in PR #12224:
URL: https://github.com/apache/datafusion/pull/12224#discussion_r1740164275
##########
datafusion/functions/src/string/concat.rs:
##########
@@ -64,13 +66,18 @@ impl ScalarUDFImpl for ConcatFunc {
&self.signature
}
- fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> {
- Ok(Utf8)
+ fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
+ use DataType::*;
+ Ok(match &arg_types[0] {
+ LargeUtf8 => LargeUtf8,
+ _ => Utf8,
+ })
Review Comment:
I've added test cases for Utf8View and LargeUtf8 return types. Have gone
ahead and adjusted this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
