alamb commented on code in PR #12274:
URL: https://github.com/apache/datafusion/pull/12274#discussion_r1740097390
##########
datafusion/core/tests/dataframe/dataframe_functions.rs:
##########
@@ -346,7 +346,7 @@ async fn test_fn_approx_median() -> Result<()> {
"+-----------------------+",
"| approx_median(test.b) |",
"+-----------------------+",
- "| 10 |",
+ "| 10.0 |",
Review Comment:
this seems like a change in behavior -- with this PR now median always
returns float but before it returned the same type as its input
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
