andygrove opened a new issue, #26308: URL: https://github.com/apache/datafusion/issues/26308
### Is your feature request related to a problem or challenge? In [`project_with_validation` (expr/src/logical_plan/builder.rs#L2087-L2174)](https://github.com/apache/datafusion/blob/0d79252f61bd8777990b2749c216ffd07079c30d/datafusion/expr/src/logical_plan/builder.rs#L2087-L2174), the `Wildcard` arm (about L2100-L2118) and the `QualifiedWildcard` arm (about L2119-L2139) are near-identical. Both duplicate the `REPLACE` handling and the `validate` branch (normalize then columnize, or pass through), and the `validate` branch is repeated a third time in the `Expression` arm. The two wildcard arms differ only in how the expanded expressions are produced. ### Describe the solution you'd like Add two small helpers, `push_validated(expr, validate)` and `apply_replace(expanded, replace)`, so each wildcard arm only computes its expansion and the rest is shared. The existing wildcard and `REPLACE` tests cover the behaviour. ### Describe alternatives you've considered None. ### Additional context This is small and self-contained, a good first issue. Line references are pinned to commit 0d79252f61bd. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
