samuel7james opened a new pull request, #2607: URL: https://github.com/apache/datafusion-ballista/pull/2607
Closes #2593. # Rationale for this change `start_time` was `Instant::now().elapsed().as_secs()`, and the loop condition used `Instant::now().elapsed().as_secs()` too. Both are about 0, so `scheduler_connect_timeout_seconds` was never reached and the executor retried forever. # What changes are included in this PR? - Store the `Instant` and compare `start_time.elapsed()` with `Duration::from_secs(connect_timeout)`. - Add `scheduler_connect_timeout_is_honoured`, which points an executor at a closed port with a 1 second timeout. It fails on the old code (still retrying after 30s) and passes with the fix. # Are there any user-facing changes? An executor with `--scheduler-connect-timeout-seconds` set now exits with the timeout error instead of retrying indefinitely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
