andygrove commented on PR #26311: URL: https://github.com/apache/datafusion/pull/26311#issuecomment-6172739483
Filed #26316 as a follow-up. One side effect of this PR worth noting: in optimized plans, a struct- or map-typed `CASE ... ELSE NULL` now fails with `Unsupported scalar: Struct(...)`, because the unparser can't render NULL struct/map literals. Before this PR the ELSE was silently dropped, which happened to give the same result. The gap already exists on `main` (`CASE ... THEN NULL` fails there today, and NULL list literals unparse as `[]`), so it belongs in its own fix rather than in this PR. Not blocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
