rank-p commented on PR #26280: URL: https://github.com/apache/datafusion/pull/26280#issuecomment-6175685833
> The NULL-aware bounds and four-way regression test look correct. I verified that reverting only the production change makes the new test fail. > > One non-blocking coverage suggestion: could we add an all-NULL file next to a non-NULL file? That would exercise the new `all_null` branch and distinguish a NULL-only point interval from an exact-empty file. Added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
