geoffreyclaude commented on code in PR #26242:
URL: https://github.com/apache/datafusion/pull/26242#discussion_r4279850056
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -88,6 +91,15 @@ struct ExternalSorterMetrics {
spill_metrics: SpillMetrics,
}
+/// Shares finite batch-sort jobs across the partitions of one [`SortExec`].
+#[derive(Debug)]
+struct SortConcurrency {
+ /// Bounds preparation futures buffered by each partition.
+ limit: usize,
Review Comment:
Yes, you can only easily get the still available permits, but we want the
total size. Renamed the field to `per_partition_limit` to clarify its purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
