jackylee-ch commented on PR #25694: URL: https://github.com/apache/datafusion/pull/25694#issuecomment-6187497810
Agreed — it should be an error. Two candidates: the provider/source boundary, or `StatisticsContext::compute_base`, where provider and built-in statistics meet; that one also covers `min_max` and `AggregateExec`, which index it the same way. One thing first: planning-time rules compute statistics (`join_selection`, `limit_pushdown`), so the broad gate also fails `SELECT * ... LIMIT` at planning time, not only `count`. With it the sqllogictests and `core_integration` pass; in `physical-plan`, two `StatisticsProvider` fixtures reporting no column statistics fail. Which do you prefer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
