0lai0 commented on code in PR #4653:
URL: https://github.com/apache/datafusion-comet/pull/4653#discussion_r4283792838
##########
dev/diffs/3.5.9.diff:
##########
@@ -1076,24 +1076,25 @@ index 3cf2bfd17ab..5bcf9478e9b 100644
val hiveVersion = "2.3.9"
// transitive=false, only download specified jar
diff --git
a/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
b/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
-index 71af1fd69c3..81a04c93c9c 100644
+index 71af1fd69c3..46340ba5740 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
-@@ -872,9 +872,24 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession with SQLHelper
+@@ -872,9 +872,25 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession with SQLHelper
s"Schema did not match for query #$i\n${expected.sql}: $output") {
output.schema
}
- assertResult(expected.output, s"Result did not match" +
-+ // Comet may surface errors as `CometNativeException` instead of the
matching Spark
-+ // exception class when a `ScalaUDF` dispatched into the native plan
evaluates a
-+ // divide-by-zero (DataFusion wraps the typed error so the JNI bridge
cannot downcast it).
-+ // Same category, different surface. Collapse both sides to a
placeholder when this happens
-+ // so the literal compare passes.
-+ // Tracking issue:
https://github.com/apache/datafusion-comet/issues/4517
++ // With parquet filter pushdown, DataFusion 54/55 formats an error
raised while
++ // evaluating a pushed-down predicate into a string, so a
divide-by-zero from a
++ // `ScalaUDF` dispatched into the native plan surfaces as
`CometNativeException`
++ // instead of `SparkArithmeticException`. Collapse both sides to a
placeholder in that
++ // case only. Remove once Comet uses a DataFusion release that includes
Review Comment:
Done. The description now says Part of #4517 and no longer mentions
`arithmetic.rs / extract_spark_error`. The Tracking issue line is back next to
the DataFusion link in all five diffs, regenerated from the Spark tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
