xanderbailey commented on PR #26310: URL: https://github.com/apache/datafusion/pull/26310#issuecomment-6194890836
Dug into point 1 a bit more. I have managed to convince myself that this is okay from a correctness point of view as it currently stands, the proper fix is what you suggested: when merging min/max in `Statistics::try_merge_iter`, skip any input with an exact `null_count == num_rows`. Since it changes general stats merging for every source, I'd prefer to do it as a separate follow-up rather than grow this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
