Nagato-Yuzuru commented on PR #25860: URL: https://github.com/apache/datafusion/pull/25860#issuecomment-6200027926
Hi @kita-renji, thank you for this fix. I work on the fuzz test plan in #24243. When I added NULL values to the window fuzz test, the test also found #25859. I opened the fuzz change as #26386. On my fuzz branch, your patch fixes the error and without it the test fails. I tested all four sort orders (ASC/DESC, NULLS FIRST/LAST). If you agree, you can cherry-pick the commits of #26386 into this PR. It make the fix and its fuzz test are in one PR. The commits apply to this branch without conflicts: ```shell git fetch https://github.com/Nagato-Yuzuru/datafusion.git fuzz-window-nulls git cherry-pick FETCH_HEAD~2..FETCH_HEAD ``` If you prefer to keep them separate also good. #26386 can merge after this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
