neilconway commented on code in PR #26377: URL: https://github.com/apache/datafusion/pull/26377#discussion_r4285936628
########## datafusion/functions/benches/string_expressions/case_conversion_inputs.rs: ########## @@ -0,0 +1,198 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Inputs shared by the `upper` and `lower` benchmarks, so both functions are +//! measured on the same arrays. + +use std::hint::black_box; +use std::sync::Arc; + +use crate::helper::gen_string_array; +use arrow::array::{Array, ArrayRef, LargeStringArray, StringArray, StringViewArray}; +use arrow::datatypes::Field; +use arrow::util::bench_util::{ + create_string_array_with_len, create_string_view_array_with_len, +}; +use criterion::Criterion; +use datafusion_common::config::ConfigOptions; +use datafusion_expr::{ColumnarValue, ScalarFunctionArgs, ScalarUDF}; + +/// Rows in each array built by [`build_values`]. +const SIZE: usize = 4096; + +const WORDS: [&str; 8] = [ + "café", + "straße", + "αλφα", + "こんにちは", + "münchen", + "naïve", + " órdenes", + "tschüß", +]; + +/// Builds [`SIZE`] values: every tenth is NULL and the rest come from `value`. +fn build_values(value: impl Fn(usize) -> String) -> Vec<Option<String>> { + (0..SIZE).map(|i| (i % 10 != 0).then(|| value(i))).collect() +} + +/// Three words from [`WORDS`], so the value is non-ASCII. +fn word_value(row: usize) -> String { + let a = WORDS[row % WORDS.len()]; + let b = WORDS[(row * 7 + 3) % WORDS.len()]; + format!("{a} {b} {a}") +} + +/// ASCII text of exactly `len` bytes that differs from row to row. +fn ascii_value(row: usize, len: usize) -> String { + let base = format!("datafusion row {row} "); + base.repeat(len / base.len() + 1)[..len].to_string() +} + +/// Returns the named input arrays. +/// +/// Entirely ASCII, which take the all-ASCII array fast path: +/// +/// - `all_ascii_utf8_rows*`: 32-byte values, 20% NULL. +/// - `all_ascii_utf8_sliced`: 128 rows sliced from the middle of a larger +/// array, so the input's buffers are much larger than the rows it uses. +/// - `all_ascii_utf8view_*`: values of `len` bytes, or with `_mixed`, half +/// under 12 bytes (stored inline in the view) and half of 12 to +/// `max(30, len)` bytes. +/// +/// Not entirely ASCII, so each row is converted on its own: +/// +/// - `some_non_ascii_utf8view_*`: 30-character values, about 10% of them +/// non-ASCII. +/// - `non_ascii_words_*`: every value is three words from [`WORDS`]. +/// - `mostly_ascii_*`: ASCII values plus one non-ASCII value in the middle. +/// - `late_non_ascii_*`: every value is ASCII text followed by one non-ASCII +/// character. +pub fn inputs() -> Vec<(String, ArrayRef)> { + let mut inputs: Vec<(String, ArrayRef)> = Vec::new(); + Review Comment: The whole benchmark setup time is ~0.4 sec locally, and building the inputs lazily or sharing them seems like it would add more complexity than is warranted. I'm inclined to leave this as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
