andygrove commented on PR #7020: URL: https://github.com/apache/datafusion-comet/pull/7020#issuecomment-6201537246
> docs/source/contributor-guide/memory_management.md (pool-stack diagram, and the section "Final aggregates reading their spill files back"). Thanks for the careful port. The SpillReplayPool description says it covers final aggregates only. With this change it also covers the SingleHashAggregateStream that Comet now uses for a PartialMerge, as the spill_replay.rs header says. Could you update both places in this PR? Also please open a matching fix for main, since #6867 did not touch the page and the two branches should agree. I went ahead and merged since this fixes a correctness bug. The suggested doc edit is for the contributors guide which we do not maintain on release branches. It only gets published from the main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
