Samearth17 commented on PR #6671: URL: https://github.com/apache/datafusion-comet/pull/6671#issuecomment-6202482259
Addressed the null-source correctness gap from the latest review: - validate duplicate struct names recursively across the full cast target before null/identity shortcuts - reject typed null literals whose declared type contains duplicate struct fields - cover direct `NullType`, `ARRAY<NULL>`, nested-null, exploded-null, and typed-null cases - merged current `upstream/main` normally (no rebase/force push) Validation on JDK 17: - focused `CometNativeCastSuite` + `CometLiteralSuite`: 2 passed - `./mvnw spotless:check -DskipTests`: passed - `git diff --check`: passed The SQL-file suite could not validate fallback annotations locally because no native Comet artifact is present; it stopped on the pre-existing first fixture query before reaching the newly added cases. CI is now running on head `f6d518f22`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
