neilconway commented on code in PR #25754:
URL: https://github.com/apache/datafusion/pull/25754#discussion_r4290006270
##########
datafusion/functions-nested/src/lambda_utils.rs:
##########
@@ -152,12 +151,10 @@ impl EvaluatedListLambda {
self.original_list.nulls()
}
- pub(crate) fn row_range(&self, i: usize) -> (usize, usize) {
- (self.row_offsets[i], self.row_offsets[i + 1])
- }
-
- pub(crate) fn adjusted_offsets<O: OffsetSizeTrait>(&self) ->
OffsetBuffer<O> {
- OffsetBuffer::from_lengths(self.row_offsets.windows(2).map(|w| w[1] -
w[0]))
+ /// Row boundaries within `flattened_values`, including the elements that
+ /// NULL rows store. Functions that walk elements row by row compute this
once.
+ pub(crate) fn row_offsets(&self) -> Result<Vec<usize>> {
+ adjusted_row_offsets(&self.original_list)
Review Comment:
Thanks, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
