geoffreyclaude commented on code in PR #26242:
URL: https://github.com/apache/datafusion/pull/26242#discussion_r4292450558
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -822,13 +955,26 @@ impl ExternalSorter {
Arc::new(self.reservation.split(retained))
});
Review Comment:
Agreed. I pushed b552b9988e1ca0df6d242c317e2a8294d3f73e66: `sort_run_sizes`
now only calculates sizes, and both callers handle the shared and per-run
reservation splits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
