andygrove opened a new pull request, #7054: URL: https://github.com/apache/datafusion-comet/pull/7054
## Which issue does this PR close? Follow-up to #4199, which is closed because it no longer reproduces on `main`. ## Rationale for this change Two tests were skipped until parquet-rs accepted Spark's encoding of a `NullType` Parquet column, `BOOLEAN` annotated `UNKNOWN`. One is Comet's own SPARK-54220 reproducer in `CometNativeReaderSuite`. The other is Spark's `SPARK-54220: vectorized reader: missing all struct fields, struct with NullType only` in `ParquetIOSuite`, which the 4.1.3 and 4.2.0 diffs ignored. apache/arrow-rs#9855 made parquet-rs accept `UNKNOWN` on any physical type, and the parquet 59 crate Comet uses includes it. ## What changes are included in this PR? - `CometNativeReaderSuite`: the reproducer runs on Spark 4.1 and later, the versions that write `NullType` columns to Parquet, behind the same `isSpark41Plus` gate as the struct test beside it. Its comment no longer says the read fails. - `dev/diffs/4.1.3.diff` and `dev/diffs/4.2.0.diff`: the `IgnoreComet` on the SPARK-54220 test is gone, and with it the diffs' only change to `ParquetIOSuite`, including the `IgnoreComet` import. Both diffs were regenerated from Spark checkouts at their tags, as `spark-sql-tests.md` describes. Before the change, applying and regenerating each diff reproduced it byte for byte. Both new diffs apply cleanly to fresh checkouts. ## How are these changes tested? The re-enabled `CometNativeReaderSuite` test passes locally on Spark 4.1 and 4.2. Spark's own SPARK-54220 test runs in the Spark SQL jobs, so this PR carries `run-spark-4.1-tests` and `run-spark-4.2-tests`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
