Lordworms commented on PR #12225: URL: https://github.com/apache/datafusion/pull/12225#issuecomment-2325414784
> I don't feel this is right - unless I misunderstood something. This tries to fix the problem at the root level of the plan, so that we'd produce the columns the plan asked for, and it works in this test case where there is only a single project in the plan, but I don't think it would work for any more complicated plan. > > I think the proper fix would be around > > https://github.com/apache/datafusion/blob/53de592381b8585f7d9de82f2ac1eb58b1524e44/datafusion/substrait/src/logical_plan/consumer.rs#L414 > > , to add all of the output fields of the project's input rel into the `exprs` list (and also `names` I guess) before adding the new expressions. Or something along those lines Thanks for the suggrestions! I'll take try and adding more test cases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
