andygrove commented on PR #7052: URL: https://github.com/apache/datafusion-comet/pull/7052#issuecomment-6228139693
Thanks both. I pushed 844e8a7ceb, which takes all the suggested rewordings. Dropped the #6264 and #6837 entries, since both are closed by #6270 and #6838 on `main`. The datetime rebase entry now covers only the native Parquet scan and says the Delta scan rebases. #5304 now has an entry for the ignored Parquet writer properties under Parquet writes, and the row-group entry says the audit did not reproduce a failure. The #7006 entry says the read schema is valid. The Spark SQL test issues are one bullet each. I also added a note under the table that `spark.comet.scan.enabled` is a testing setting. On #7032, top-level values match Spark in a release build, because the invalid bytes reach an Arrow string array unchecked. A debug build panics. The entry now says so. On iceberg#17320, it is the same fix even though the title names nested initial defaults. The change keeps one file column in the read when every projected field of a struct is a constant, so the struct's definition level survives, and an identity partition value is such a constant. It is in 1.12.0. I added that to the entry and to the Iceberg audit page. I read the change but did not run it against a partitioned table. The `IgnoreComet` tags for SPARK-54220 in `4.1.3.diff` and `4.2.0.diff` are not part of this PR. #7054 re-enables them through the regenerate-the-diff workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
