andygrove commented on PR #7097: URL: https://github.com/apache/datafusion-comet/pull/7097#issuecomment-6248308187
Thanks for the PR, @Jbansal2. The issue asked for a before-and-after `shuffle_writer` benchmark and said to drop the change if it was within noise. @HarshilMital, who had the issue assigned, already ran that comparison on dedicated hardware and found no measurable difference on the paths that use `buffer_partitioned_batch_may_spill` ([comment](https://github.com/apache/datafusion-comet/issues/7072)). So I'm going to close this one and the issue rather than merge a change with no measured benefit. For next time, it's worth checking whether an issue is already assigned, and whether it has a benchmark or other acceptance step, before opening a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
