andygrove commented on PR #903: URL: https://github.com/apache/datafusion-comet/pull/903#issuecomment-2326864670
`NativeUtil` creates a new dictionary provider per instance. ```scala private val dictionaryProvider: CDataDictionaryProvider = new CDataDictionaryProvider ``` It is probably not safe to share one dictionary provider globally because the same dictionary id could be re-used in different contexts? It is probably not surprising that this PR causes failures, but I would not expect segmentation faults. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
