choksi2212 commented on PR #26482: URL: https://github.com/apache/datafusion/pull/26482#issuecomment-6250649615
Hi! This is my first PR to DataFusion, so the workflow runs need a maintainer approval to start. Happy to wait, but flagging it here in case it slipped through. For reviewers, everything was verified locally on top of 61c3472: - `cargo test -p datafusion-functions-aggregate --lib bit_xor`: 4/4, including the three new accumulator tests - New `bit_xor_sliding_window.slt` (modeled on `array_agg_sliding_window.slt`): runs green end to end - Negative control: with only the `evaluate` guard reverted, exactly the two all-NULL-frame tests fail with `UInt64(0)` vs `UInt64(NULL)`, which is the issue symptom; the regression pins keep passing - `rustfmt --check` and `cargo clippy -p datafusion-functions-aggregate --all-targets` clean The legitimate-zero case (a frame holding two equal values XORs to 0 and must stay 0) is pinned in the sqllogictest file, so the NULL guard can't be over-applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
