0lai0 commented on PR #5050: URL: https://github.com/apache/datafusion-comet/pull/5050#issuecomment-6252015864
Thanks for the extra context on the 1.2.0 regression and on vanilla Spark's behavior across a shuffle. Agreed that returning the value is the right side to be on. All six are addressed. Verified: `spotless:check` clean, `./mvnw -B test-compile -Pspark-3.5,delta -Pstrict-warnings -DskipTests` clean, `cargo clippy --all-targets --workspace -- -D warnings` clean, and nine suites green with 606 passing. One thing worth mentioning: moving the width calculation out left `std::cmp::max` unused in `planner.rs`, which `make core` does not flag because it only builds the lib. Clippy caught it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
