sunchao commented on PR #5420: URL: https://github.com/apache/datafusion-comet/pull/5420#issuecomment-6272853375
@andygrove @mbutrovich @comphead Rebased onto main `80b518173` and pushed `8c1658a9a4f4459b470ebec7848c73f3eed484be`. The conflicts are resolved, and the branch now includes the review follow-up changes. I replied to each inline thread: - [Wider scalar AVG accumulator](https://github.com/apache/datafusion-comet/pull/5420#discussion_r4316318017): took the suggested follow-up option, opened #7116, and linked it from the operator guide. - [Decimal error formatter](https://github.com/apache/datafusion-comet/pull/5420#discussion_r4316318465): switched to `Decimal256Type::format_decimal`, matching SUM. - [Error-message value](https://github.com/apache/datafusion-comet/pull/5420#discussion_r4316319023): confirmed the scale-39 Spark quotient and added the requested diagnostic-divergence note. - [Test placement](https://github.com/apache/datafusion-comet/pull/5420#discussion_r4316319464): moved the suitable cases into `avg.sql` and `avg_ansi.sql`, retaining partition-sensitive Scala coverage. The rebase preserves main's newer sort/object/window fallback policies and removes the temporary rescaling fallback that this PR's division fix supersedes. Local validation passed all five native AVG tests and 326 Spark 4.0 tests, including both SQL fixtures. Local Spark 4.1 dependency resolution was blocked by the configured Maven mirror's DNS. On this head, hosted preflight, lint, cross-version compilation, native build, and Rust tests have passed. The Comet runtime matrix and Spark 4.1 SQL checks are still running in [CI](https://github.com/apache/datafusion-comet/actions/runs/39286631987). The PR description has the full validation scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
