viirya commented on PR #6427:
URL: 
https://github.com/apache/datafusion-comet/pull/6427#issuecomment-6274888264

   Thanks for tracing the original case and adding the end-to-end test. That 
settles reachability for me.
   
   Now that `summarizeBloomLiterals` is a shared helper, the same 
application-built predicate placed in a `select(...)` still renders the full 
payload. `CometExec3_4PlusSuite` already runs `SELECT might_contain(X'...', 
col1) FROM ...` natively, so that case is a `CometProjectExec`. 
`CometProjectExec` only overrides `stringArgs`, and the default 
`verboseStringWithOperatorId` reads `argString`. So `Iterator(output, 
projectList.map(CometExpressionDisplay.summarizeBloomLiterals), child)` would 
cover the plan string, formatted EXPLAIN and the SQL UI in one line. Could you 
apply it here? If you'd rather keep this PR to filters, could you open a 
tracking issue for the projection case and the upstream Spark formatting 
follow-up?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to