berkaysynnada commented on code in PR #12281:
URL: https://github.com/apache/datafusion/pull/12281#discussion_r1743240999
##########
datafusion/physical-expr/src/equivalence/projection.rs:
##########
@@ -82,6 +82,11 @@ impl ProjectionMapping {
.map(|map| Self { map })
}
+ pub fn from_indices(indices: &[usize], schema: &SchemaRef) -> Result<Self>
{
Review Comment:
A brief docstring would be helpful
##########
datafusion/core/src/physical_optimizer/projection_pushdown.rs:
##########
@@ -535,11 +538,27 @@ fn try_pushdown_through_union(
Ok(Some(Arc::new(UnionExec::new(new_children))))
}
+trait EmbededProjection: ExecutionPlan + Sized {
Review Comment:
EmbededProjection -> EmbeddedProjection
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -191,6 +194,28 @@ impl Partitioning {
_ => false,
}
}
+
+ pub fn project(
Review Comment:
Can we write a docstring here also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
