dwsmith1983 commented on code in PR #7127:
URL: https://github.com/apache/datafusion-comet/pull/7127#discussion_r4332865464
##########
native/core/src/parquet/objectstore/azure.rs:
##########
@@ -120,9 +122,12 @@ pub fn create_store(
url: &Url,
configs: &HashMap<String, String>,
) -> Result<(Box<dyn ObjectStore>, Path), object_store::Error> {
- let (scheme, path) = ObjectStoreScheme::parse(url)?;
+ let (scheme, path) = ObjectStoreScheme::parse(&without_credentials(url))?;
if scheme != ObjectStoreScheme::MicrosoftAzure {
- return Err(config_error(format!("Scheme of URL is not Azure: {url}")));
+ return Err(config_error(format!(
+ "Scheme of URL is not Azure: {}",
+ redacted(url)
+ )));
Review Comment:
It was there before this PR and mirrors the `Scheme of URL is not S3` check
in `s3.rs`, so I kept the branch since `create_store` is `pub`. It now names
only the scheme in a3275e668, and `redacted` is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
