XiangpengHao commented on code in PR #12032:
URL: https://github.com/apache/datafusion/pull/12032#discussion_r1744229803
##########
datafusion/functions/src/regex/regexpreplace.rs:
##########
@@ -401,8 +401,7 @@ fn _regexp_replace_static_pattern_replace<T:
OffsetSizeTrait>(
DataType::Utf8View => {
let string_view_array = as_string_view_array(&args[0])?;
- let mut builder =
StringViewBuilder::with_capacity(string_view_array.len())
- .with_block_size(1024 * 1024 * 2);
+ let mut builder =
StringViewBuilder::with_capacity(string_view_array.len());
Review Comment:
yes, we don't need it after this pr is merged:
https://github.com/apache/arrow-rs/pull/6136
I ran a local benchmark and show no perf diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
