viirya commented on code in PR #909:
URL: https://github.com/apache/datafusion-comet/pull/909#discussion_r1744282163
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -1347,12 +1349,24 @@ impl PhysicalPlanner {
match datatype {
DataType::Decimal128(_, _) => {
- Ok(Arc::new(SumDecimal::new("sum", child, datatype)))
+ let func = AggregateUDF::new_from_impl(SumDecimal::new(
+ "sum",
+ Arc::clone(&child),
Review Comment:
Hmm, I think the second parameter is `Arc<dyn PhysicalExpr>`. If it is not
changed, it should be `child`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
