geoffreyclaude commented on code in PR #25187: URL: https://github.com/apache/datafusion/pull/25187#discussion_r4337694969
########## datafusion/sqllogictest/test_files/eliminate_outer_join.slt: ########## @@ -97,9 +97,9 @@ explain select * from t1 left join t2 on t1.a = t2.x where t2.x in (1, 2, null); ---- logical_plan 01)Inner Join: t1.a = t2.x -02)--Filter: t1.a = Int32(1) OR t1.a = Int32(2) +02)--Filter: t1.a IN ([Int32(1), Int32(2), Int32(NULL)]) Review Comment: Agreed, retaining the IN list loses that filter simplification here. It should be done in a follow-up change: looks like we already have a candidate PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
