Rachelint commented on code in PR #11827:
URL: https://github.com/apache/datafusion/pull/11827#discussion_r1745201830
##########
datafusion/physical-expr/src/aggregate/groups_accumulator/adapter.rs:
##########
@@ -342,6 +374,50 @@ impl GroupsAccumulator for GroupsAccumulatorAdapter {
fn size(&self) -> usize {
self.allocation_bytes
}
+
+ fn convert_to_state(
Review Comment:
Found the quick way using `filtered_null_mask` + `set_nulls` will just set
the filtered row to be null, but now change the row num.
```rust
// `filtered_null_mask` + `set_nulls`
left: PrimitiveArray<Int32>
[
null,
null,
6,
null,
null,
null,
]
// `compute::filter`
right: PrimitiveArray<Int32>
[
null,
6,
]
```
Maybe this will make difference to the correctness for some accumulators?
For example, an udf count which thinks a null row as 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
