neilconway commented on PR #26507: URL: https://github.com/apache/datafusion/pull/26507#issuecomment-6348006078
@mbutrovich > sort_rows_with_nulls in array_sort still slices the element validity and counts it for each row ([sort.rs](https://github.com/apache/datafusion/blob/6c1727fcd9230dda428f8c3a2397fce235544bd5/datafusion/functions-nested/src/sort.rs#L330-L342)). Should it use SetBitCounter too, or does the per-row sort cost hide the difference there? I measured using `SetBitCounter` for `array_sort` as part of #26453, but the approach we took in that PR is faster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
