mbutrovich commented on issue #26661:
URL: https://github.com/apache/datafusion/issues/26661#issuecomment-6371248508

   > I also filed a issue about inconsistent EPOCH truncation (which I think is 
related to some of the db olympics failures)
   > 
   > * [`EXTRACT EPOCH` inconsistently extracts fractional secondsĀ 
#26673](https://github.com/apache/datafusion/issues/26673)
   
   Nice, thank you! This is the cause of the remaining SF1 wrong results in the 
benchmark: q124, q127, q128, q197 and q405 all average or take a percentile of 
`CAST(EXTRACT(EPOCH FROM (ts1 - ts2)) AS NUMERIC(18,6))`. With the expression 
replaced by `(CAST(ts1 AS BIGINT) - CAST(ts2 AS BIGINT)) / 1000000.0`, all five 
match the reference results. Together with the `year_month` dialect change and 
#26671, DataFusion 55.0.0 at SF1 has no wrong results left (331 equal, 0 
different, 78 queries that return errors).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to